Remove VirtualNetwork from (most of) card API#5349
Draft
backspace wants to merge 2 commits into
Draft
Conversation
Contributor
Preview deploymentsHost Test Results 1 files ± 0 1 suites ±0 2h 13m 28s ⏱️ + 6m 18s Results for commit cc4d2a3. ± Comparison against earlier commit 674b39c. Realm Server Test Results 1 files ±0 1 suites ±0 10m 7s ⏱️ +52s Results for commit cc4d2a3. ± Comparison against earlier commit 674b39c. |
…and serialize paths Identifiers are canonical RRI inside the runtime, so the form-bridging that was threaded through these interior paths is no longer needed: - resolveRef resolves relative references with pure RRI path math (new resolveRRIReference in url.ts); no VirtualNetwork. - isLocalId is a pure syntactic test (not a URL, not an @-prefix). - SerializeOpts no longer carries a VirtualNetwork; the serialize path (card-serialization.ts, serializers/code-ref.ts) preserves prefix-form refs and resolves URL-form refs with plain URL math. The host Store's asURL keeps resolving keys to normalized URL form (via the VN) so it stays consistent with gc-card-store, which keys instances by their URL-form data.id. Collapsing the store's canonical key to an opaque RRI token is deferred to CS-11730 — it needs gc-card-store keyed the same way and must preserve the URL normalization toURL provides. VirtualNetwork stays where it resolves an RRI to a real URL at the network boundary (document loading), at render-time pill resolution, and for the Store's URL-form keying. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
cs-11450-remove-vn-threading-card-api-store
branch
from
6516d9e to
674b39c
Compare
…reading-card-api-store # Conflicts: # packages/base/card-api.gts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the runtime works with RRIs, virtual networks shouldn’t be needed in the card API. This removes most of them, but excludes pills and query fields, which await #5356.